So in my programming class we are working on a program that will make determine if three entered sides create a triangle and what type of triangle it is. It needs to loop but I cant get it to loop correctly and it wont display error, just scalene, if it is a incorrect triangle.
Here are the instructions:
Here is the code I currently have done.
Yes it must have two methods
/*
* Lukas Turner
* Triangle Test
* NA
* 2-1-2016
*/
import java.util.Scanner;
public class TriangleTest{
public static void main(String[]args){
System.out.print("\f");
int a;
int b;
int c;
boolean rar = false;
Scanner george = new Scanner(System.in);
do{
System.out.println("Please Enter the Length of Side 1: ");
a = george.nextInt();
System.out.println("Please enter the length of side 2: ");
b = george.nextInt();
System.out.println("Please enter the length of side 3: ");
c = george.nextInt();
typeOfTriangle(a,b,c);
}while(rar = false);
// print
String type = typeOfTriangle(a,b,c);
System.out.println(type);
}
public static String typeOfTriangle(int a, int b, int c){
boolean ba = false;
if(a == b && b == c){
return("equilateral");
}else if(a == b || b == c || a == c){
return("Isosceles");
}else if(a != b && b != c && a != c && (a+b<c || a+c<b || b+c<a)){
return("Scalene");
}else{
return("error");
}
}
}
thanks for any help guys, my brain is kind of dead right now lol
Moved the topic to "Code". :)
thanks man, didnt know there was a code section, sorry about that
See if this is what you are wanting it to do. I will explain the problem if it is, but I am not sure that this is functioning as it should (as it doesn't check to make sure that it actually is a triangle, but maybe you are just to assume that the dimensions that you are given are actually of a triangle, so it is never a problem in which case it works fine).
import java.util.Scanner;
public class TriangleTest{
public static void main(String[]args){
Scanner george = new Scanner(System.in);
int a=0;
int b=0;
int c=0;
System.out.print("\f");
while(a!=-1){
System.out.println("Please Enter the Length of Side 1: ");
a = george.nextInt();
System.out.println("Please enter the length of side 2: ");
b = george.nextInt();
System.out.println("Please enter the length of side 3: ");
c = george.nextInt();
System.out.println(typeOfTriangle(a,b,c)+"\n");
}
}
public static String typeOfTriangle(int a, int b, int c){
if(a == b && b == c){
return("equilateral");
}else if(a == b || b == c || a == c){
return("Isosceles");
}else if(a != b && b != c && a != c){
return("Scalene");
}else{
return("error");
}
}
}
EDIT: If you want to use this requirement before giving an error (and I think this is the part that checks to make sure it actually is a triangle, but I have long forgotten geometry), then make a new if statement between the first scalene and the error which will function as the && without giving any issues and being easier to comprehend. (a+b<c || a+c<b || b+c<a)
I got tired of waiting on a response, and I don't have much time to sit here before I have to go, so I am just going to go ahead and explain this so you can read it whenever (or just take the answer and be done with it if you don't care about learning shit).
I changed the loop because I didn't see any reason for it to be looped the way that you had it. It didn't actually accomplish anything since nothing was supposed to get executed more than once. I figured you still wanted to haev a loop of some sort in there, so there you go. Now you can loop through it as many times as you want and check tons of different configs rather quickly. -1 is a common way to get out of a loop or to just reply in the negative, so that is what I used to end the program. Pretty common stuff there.
I realized that it was returning error because it didn't like the requirements for the the last if statement. Having or and and together in a conditional is sometimes weird, so I jsut separated it out to make it easy.
And now it works. Here is the updated code with the triangle check moved to its own if statement.
public static String typeOfTriangle(int a, int b, int c){
if(a == b && b == c){
return("Equilateral");
}else if(a == b || b == c || a == c){
return("Isosceles");
}else if(a != b && b != c && a != c){
return("Scalene");
}else if(a+b<c || a+c<b || b+c<a){
return("Scalene");
}else{
return("error");
}
}
Im sorry lol, I was doing other homework
This should work, added a dirty exception in there to handle quitting. You can deal with that however you want. For the triangle, in actual code I would create an InvalidTriangleException class and throw that but I am guessing you aren't familiar with creating exceptions yet. Can still be improved on but who has the time to deal with Java... back to Clojure land I go.
To answer your question about not displaying error, it's best to do error checking first when it comes to input validation IMO, makes the code much more readable and doesn't mix logic.
import java.util.InputMismatchException;
import java.util.Scanner;
public class Main {
public static void main(String[] args) {
Scanner scanner = new Scanner(System.in);
double a = 0;
double b = 0;
double c = 0;
boolean running = true;
System.out.println("Type 'quit' at any time to exit. Invalid input ignored\n");
do {
try {
System.out.print("Enter the side lengths individually or as a list of space delimited lengths: ");
a = scanner.nextDouble();
b = scanner.nextDouble();
c = scanner.nextDouble();
System.out.printf("The triangle is %s\n\n", typeOfTriangle(a, b, c));
} catch (InputMismatchException e) {
if (scanner.nextLine().equalsIgnoreCase("quit"))
running = false;
}
} while(running);
System.out.println("Goodbye");
}
public static String typeOfTriangle(double a, double b, double c) {
if (a + b <= c || a + c <= b || b + c <= a)
return "Error";
if (a == b && b == c)
return "Equilateral";
else if (a == b || b == c || a == c)
return "Isosceles";
else
return "Scalene";
}
}
