For my master collection archive, it's FLAC.
For portable devices... it depends. I used to use MP3 because everything supported it, but when I got an iPhone, I re-ripped to AAC.
When I switch to Android, I'll probably go with ogg/vorbis for portable devices. Or I might use FLAC. Not sure - I don't know what is supported.